feat(input): support notch with label slot #27635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liamdebeasi
requested review from
a team and
thetaPC
and removed request for
a team
liamdebeasi
requested review from
a team and
brandyscarney
and removed request for
a team
brandyscarney
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Is there something we could do here to capture the entire label? Maybe add some margin top or something?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Input support slotted labels, but the notch cut out behavior does not work.
What is the new behavior?
Note: Dynamically updating the slotted content will not re-render the notch. This is being handled in a separate PR.
Does this introduce a breaking change?
Other information